Skip to content

Court report submission status#912

Merged
compwron merged 6 commits into
rubyforgood:masterfrom
steve-meyers:court_report_submission_status
Oct 3, 2020
Merged

Court report submission status#912
compwron merged 6 commits into
rubyforgood:masterfrom
steve-meyers:court_report_submission_status

Conversation

@steve-meyers

@steve-meyers steve-meyers commented Oct 3, 2020

Copy link
Copy Markdown
Collaborator

What github issue is this PR for, if any?

Resolves #882

What changed, and why?

On the CASA Case Details view there is a line that reads:
Court Report Submission: Not Submitted IF Course Report Submitted is NOT checked on the CASA Case edit page
or
Court Report Submission: Submitted IF Course Report Submitted is checked on the CASA Case edit page

How will this affect user permissions?

  • Volunteer permissions: N/A
  • Supervisor permissions: N/A
  • Admin permissions: N/A

How is this tested? (please write tests!) 💖💪

  • I added a decorator test (note: the previously added CasaCaseDecorator methods don't have tests yet)
  • I updated volunteer_edits_a_case_spec.rb and supervisor_edits_a_case_spec.rb (note: there seems to be a hold on the admin_edits_a_case_spec.rb due to a TravisCI issue so I didn't add to that test)

Screenshots please :)

Screen Shot 2020-10-02 at 8 35 33 PM

Other Notes

  • I wasn't able to get the JS test suite to run
  • I ran the 3 linter commands in the README and it changed a lot! I am guessing it hadn't been run in a while so hopefully, that doesn't cause any issues. The RSpec test passes after the linter changes but I can't double-check that the JS tests still pass.
  • I would be happy to revert the linter changes if they cause problems

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
alt text

@compwron compwron mentioned this pull request Oct 3, 2020
Merged
compwron
compwron approved these changes Oct 3, 2020
View reviewed changes

@compwron compwron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and I love the tests!
In general, avoid putting a big linter changeset in the same PR as non-lint work because it makes the PR difficult to review, especially if there's not a separate build for the changes-without-lint.
I made a copy of your branch without linting at https://github.com/rubyforgood/casa/pull/913/files to see the build pass. When that passes, I'll merge this PR, since some lint is nice to have- in retrospect I should have run it before hacktober but we were still recovering from power week 😅

@compwron compwron merged commit f412247 into rubyforgood:master Oct 3, 2020
@jmkoni jmkoni added the hacktoberfest-accepted Accepted for Hacktoberfest label Oct 5, 2020
@compwron

compwron commented Nov 12, 2020

Copy link
Copy Markdown
Collaborator

You are invited to the CASA asynchronous retrospective-and-futurespective! Please take a look at https://bit.ly/casaretro (no login required) and add at least one note! Even if it's just "I was here and you are cool" or "omg y'all why do you keep messaging me" we want to hear it. <3
Next week Wednesday 18 November @ 6pm Pacific time we will Zoom about the board and talk about themes and takeaways. (Zoom link in our calendar at http://bit.ly/casacal or slack #casa channel https://rubyforgood.herokuapp.com/ )
Please ESPECIALLY add lots of notes if you won't be able to make it on Wednesday to talk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compwron compwron compwron approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted for Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

court report submission status updates automatically

3 participants

@steve-meyers @compwron @jmkoni